[
https://issues.apache.org/jira/browse/BEAM-7239?focusedWorklogId=241520&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241520
]
ASF GitHub Bot logged work on BEAM-7239:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/19 05:03
Start Date: 14/May/19 05:03
Worklog Time Spent: 10m
Work Description: jbonofre commented on issue #8565: [BEAM-7239] Do not
close DataSource on Teardown on JdbcIO
URL: https://github.com/apache/beam/pull/8565#issuecomment-492079706
The Jira is talking about lot of `Connection` which is closed in `teardown`
already. I'm OK to close the `DataSource` itself but I'm not sure it will
actually limit the connections or it's a side effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 241520)
Time Spent: 4h 10m (was: 4h)
> Add withDataSourceProviderFn() to JdbcIO
> ----------------------------------------
>
> Key: BEAM-7239
> URL: https://issues.apache.org/jira/browse/BEAM-7239
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.13.0
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> We have been manually tuning Datasource creation, a better approach would be
> to generalize this and allow users to parametrize their DataSource creation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
