[
https://issues.apache.org/jira/browse/BEAM-3061?focusedWorklogId=267432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-267432
]
ASF GitHub Bot logged work on BEAM-3061:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/19 09:53
Start Date: 26/Jun/19 09:53
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7805: [BEAM-3061]
Done notifications for BigtableIO.Write
URL: https://github.com/apache/beam/pull/7805#discussion_r297579025
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
##########
@@ -466,7 +469,7 @@ public String toString() {
@Experimental(Experimental.Kind.SOURCE_SINK)
@AutoValue
public abstract static class Write
- extends PTransform<PCollection<KV<ByteString, Iterable<Mutation>>>,
PDone> {
+ extends PTransform<PCollection<KV<ByteString, Iterable<Mutation>>>,
PCollection<Void>> {
Review comment:
@robertwb may have a point but it `?` have other trade-offs too. I am going
to open a discussion thread on the ML around the return types of Write
transforms to maybe have other opinions and to not fill this PR with the
pros/cons of each approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 267432)
Time Spent: 13h 50m (was: 13h 40m)
> BigtableIO should support emitting a sentinel "done" value when a bundle
> completes
> ----------------------------------------------------------------------------------
>
> Key: BEAM-3061
> URL: https://issues.apache.org/jira/browse/BEAM-3061
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: Major
> Time Spent: 13h 50m
> Remaining Estimate: 0h
>
> There was some discussion of this on the dev@ mailing list [1]. This
> approach was taken based on discussion there.
> [1]
> https://lists.apache.org/thread.html/949b33782f722a9000c9bf9e37042739c6fd0927589b99752b78d7bd@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
