[ https://issues.apache.org/jira/browse/BEAM-3061?focusedWorklogId=275053&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-275053 ]
ASF GitHub Bot logged work on BEAM-3061: ---------------------------------------- Author: ASF GitHub Bot Created on: 10/Jul/19 20:27 Start Date: 10/Jul/19 20:27 Worklog Time Spent: 10m Work Description: jkff commented on pull request #7805: [BEAM-3061] Done notifications for BigtableIO.Write URL: https://github.com/apache/beam/pull/7805#discussion_r302252812 ########## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java ########## @@ -660,6 +690,17 @@ Write withBigtableService(BigtableService bigtableService) { return toBuilder().setBigtableConfig(config.withBigtableService(bigtableService)).build(); } + /** + * Returns a {@link BigtableIO.WriteWithResults} that will emit a {@link BigtableWriteResult} + * for each batch of rows written. + * + * <p>Does not modify this object. Review comment: "Does not modify this object" is redundant, it is true for all methods of all builders in Beam. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 275053) Time Spent: 15h 20m (was: 15h 10m) > BigtableIO should support emitting a sentinel "done" value when a bundle > completes > ---------------------------------------------------------------------------------- > > Key: BEAM-3061 > URL: https://issues.apache.org/jira/browse/BEAM-3061 > Project: Beam > Issue Type: Improvement > Components: io-java-gcp > Reporter: Steve Niemitz > Assignee: Steve Niemitz > Priority: Major > Time Spent: 15h 20m > Remaining Estimate: 0h > > There was some discussion of this on the dev@ mailing list [1]. This > approach was taken based on discussion there. > [1] > https://lists.apache.org/thread.html/949b33782f722a9000c9bf9e37042739c6fd0927589b99752b78d7bd@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)