[
https://issues.apache.org/jira/browse/BEAM-7545?focusedWorklogId=276895&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276895
]
ASF GitHub Bot logged work on BEAM-7545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/19 17:58
Start Date: 15/Jul/19 17:58
Worklog Time Spent: 10m
Work Description: riazela commented on pull request #9040: [BEAM-7545]
Reordering Beam Joins
URL: https://github.com/apache/beam/pull/9040#discussion_r303537888
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/BeamRuleSets.java
##########
@@ -103,6 +106,10 @@
// join rules
JoinPushExpressionsRule.INSTANCE,
+ JoinCommuteRule.INSTANCE,
Review comment:
I have tested the effect of adding these rules in terms of performance gain
in:
https://docs.google.com/document/d/1DM_bcfFbIoc_vEoqQxhC7AvHBUDVCAwToC8TYGukkII/edit#
However, in terms of testing against bugs, all I can say is it is passing
our current tests; therefore, if it can create illegal plans for some query,
that means we are not covering it in our tests and it should be added. I am not
sure how we can test this against all possible scenarios and queries. I think
one way to improve our test cases is checking other systems' tests (Such as
Calcite's test cases) and add them to ours. I will appreciate if you have any
suggestion for that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 276895)
Time Spent: 6h (was: 5h 50m)
> Row Count Estimation for CSV TextTable
> --------------------------------------
>
> Key: BEAM-7545
> URL: https://issues.apache.org/jira/browse/BEAM-7545
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Alireza Samadianzakaria
> Assignee: Alireza Samadianzakaria
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Implementing Row Count Estimation for CSV Tables by reading the first few
> lines of the file and estimating the number of records based on the length of
> these lines and the total length of the file.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
