[
https://issues.apache.org/jira/browse/BEAM-7545?focusedWorklogId=276933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276933
]
ASF GitHub Bot logged work on BEAM-7545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/19 18:58
Start Date: 15/Jul/19 18:58
Worklog Time Spent: 10m
Work Description: akedin commented on pull request #9040: [BEAM-7545]
Reordering Beam Joins
URL: https://github.com/apache/beam/pull/9040#discussion_r303586595
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rule/BeamJoinPushThroughJoinRule.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.sql.impl.rule;
+
+import org.apache.beam.sdk.extensions.sql.impl.rel.BeamJoinRel;
+import org.apache.calcite.plan.RelOptRule;
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.rel.core.Join;
+import org.apache.calcite.rel.core.RelFactories;
+import org.apache.calcite.rel.logical.LogicalJoin;
+import org.apache.calcite.rel.rules.JoinPushThroughJoinRule;
+import org.apache.calcite.tools.RelBuilderFactory;
+
+/**
+ * This is exactly similar to {@link
org.apache.calcite.rel.rules.JoinPushThroughJoinRule}. It only
+ * checks if the condition of the new bottom join is supported.
+ */
+public class BeamJoinPushThroughJoinRule extends JoinPushThroughJoinRule {
+ /** Instance of the rule that works on logical joins only, and pushes to the
right. */
+ public static final RelOptRule RIGHT =
+ new BeamJoinPushThroughJoinRule(
+ "BeamJoinPushThroughJoinRule:right",
+ true,
+ LogicalJoin.class,
+ RelFactories.LOGICAL_BUILDER);
+
+ /** Instance of the rule that works on logical joins only, and pushes to the
left. */
+ public static final RelOptRule LEFT =
+ new BeamJoinPushThroughJoinRule(
+ "BeamJoinPushThroughJoinRule:left",
+ false,
+ LogicalJoin.class,
+ RelFactories.LOGICAL_BUILDER);
+
+ /** Creates a JoinPushThroughJoinRule. */
+ private BeamJoinPushThroughJoinRule(
+ String description,
+ boolean right,
+ Class<? extends Join> clazz,
+ RelBuilderFactory relBuilderFactory) {
+ super(description, right, clazz, relBuilderFactory);
+ }
+
+ @Override
+ public void onMatch(RelOptRuleCall call) {
+ super.onMatch(
+ new JoinRelOptRuleCall(
Review comment:
just an idea to think about, don't know if it makes sense:
* implement the check `BeamJoinRel.isJoinLegal(topJoin) &&
BeamJoinRel.isJoinLegal(bottomJoin)` in `JoinRelOptRuleCall`;
* create an interface like `JoinInputNodesMatcher` or something, which
returns the top and the bottom join from the node, e.g.:
```java
interface JoinInputNodesMatcher implements ... {
Pair<Join, Join> getTopAndBottomJoin(RelOptRuleCall call);
default void onMatch(RelOptRuleCall call) {
super.onMatch(new JoinRelOptRuleCall(this));
}
}
```
* make the `BeamJoinPushThroughJoinRule` implement that interface;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 276933)
Time Spent: 6h 20m (was: 6h 10m)
> Row Count Estimation for CSV TextTable
> --------------------------------------
>
> Key: BEAM-7545
> URL: https://issues.apache.org/jira/browse/BEAM-7545
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Alireza Samadianzakaria
> Assignee: Alireza Samadianzakaria
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> Implementing Row Count Estimation for CSV Tables by reading the first few
> lines of the file and estimating the number of records based on the length of
> these lines and the total length of the file.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
