[ 
https://issues.apache.org/jira/browse/BEAM-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890365#comment-16890365
 ] 

Reuven Lax commented on BEAM-6858:
----------------------------------

Some more details:

We need to add a way for the user to control the name of the SideInput in the 
PCollectionView. I think we should add new overloads to the factory methods. 
e.g.

PCollectionView<Integer> sideInput1 = 
.....apply("View.asSingleton("sideInput1"));

PCollectionView<List<String>> sideInput2 = ...apply("View.asList("sideInput2"))

These names can then be used to generate the side input.

> Support side inputs injected into a DoFn
> ----------------------------------------
>
>                 Key: BEAM-6858
>                 URL: https://issues.apache.org/jira/browse/BEAM-6858
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Reuven Lax
>            Assignee: Shehzaad Nakhoda
>            Priority: Major
>
> Beam currently supports injecting main inputs into a DoFn process method. A 
> user can write the following:
> @ProcessElement public void process(@Element InputT element)
> And Beam will (using ByteBuddy code generation) inject the input element into 
> the process method.
> We would like to also support the same for side inputs. For example:
> @ProcessElement public void process(@Element InputT element, 
> @SideInput("tag1") String input1, @SideInput("tag2") Integer input2) 
> This requires the existing process-method analysis framework to capture these 
> side inputs. The ParDo code would have to verify the type of the side input 
> and include them in the list of side inputs. This would also eliminate the 
> need for the user to explicitly call withSideInputs on the ParDo.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to