[ https://issues.apache.org/jira/browse/BEAM-7802?focusedWorklogId=288829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-288829 ]
ASF GitHub Bot logged work on BEAM-7802: ---------------------------------------- Author: ASF GitHub Bot Created on: 05/Aug/19 09:49 Start Date: 05/Aug/19 09:49 Worklog Time Spent: 10m Work Description: kanterov commented on pull request #9130: [BEAM-7802] Expose a method to make an Avro-based PCollection into an Schema-based one URL: https://github.com/apache/beam/pull/9130#discussion_r310511199 ########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java ########## @@ -127,7 +127,7 @@ public static FixedBytesField withSize(int size) { /** Create a {@link FixedBytesField} from a Beam {@link FieldType}. */ @Nullable - public static FixedBytesField fromBeamFieldType(FieldType fieldType) { + static FixedBytesField fromBeamFieldType(FieldType fieldType) { Review comment: I see that you want to hide internal APIs, but I'm not sure it worth it at the moment. Everything in this file is an unstable internal API, and it's used outside of Beam codebase to workaround existing limitations. At Spotify, we use a few of these methods, and it seems there are other contributors following this pattern (for instance, https://github.com/apache/beam/commit/172b563fdd36019d3284139417808681314ac364#diff-d7153fa055ebd85f76700232cb4e5cce). I would say for now it's completely fine to keep everything public as is, class is annotated with `@Experimental` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 288829) Time Spent: 1h 10m (was: 1h) > Expose a method to make an Avro-based PCollection into an Schema-based one > -------------------------------------------------------------------------- > > Key: BEAM-7802 > URL: https://issues.apache.org/jira/browse/BEAM-7802 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Ismaël Mejía > Assignee: Ismaël Mejía > Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > Avro can infer the Schema for an Avro based PCollection by using the > `withBeamSchemas` method, however if the user created a PCollection with Avro > objects or IndexedRecord/GenericRecord, he needs to manually set the schema > (or coder). The idea is to expose a method in schema.AvroUtils to ease this. -- This message was sent by Atlassian JIRA (v7.6.14#76016)