[
https://issues.apache.org/jira/browse/BEAM-7802?focusedWorklogId=289160&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-289160
]
ASF GitHub Bot logged work on BEAM-7802:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/19 19:30
Start Date: 05/Aug/19 19:30
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #9130: [BEAM-7802]
Expose a method to make an Avro-based PCollection into an Schema-based one
URL: https://github.com/apache/beam/pull/9130#discussion_r310757382
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java
##########
@@ -127,7 +127,7 @@ public static FixedBytesField withSize(int size) {
/** Create a {@link FixedBytesField} from a Beam {@link FieldType}. */
@Nullable
- public static FixedBytesField fromBeamFieldType(FieldType fieldType) {
+ static FixedBytesField fromBeamFieldType(FieldType fieldType) {
Review comment:
Well I think because `@Experimental` is applied to the full class we will
probably end up exposing more stuff than we want when we remove the annotation.
keeping it with the lowest possible access level is probably wiser and will
still allow to evolve access if needed (the other way around won't work). But I
can change it if you prefer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 289160)
Time Spent: 1h 40m (was: 1.5h)
> Expose a method to make an Avro-based PCollection into an Schema-based one
> --------------------------------------------------------------------------
>
> Key: BEAM-7802
> URL: https://issues.apache.org/jira/browse/BEAM-7802
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Avro can infer the Schema for an Avro based PCollection by using the
> `withBeamSchemas` method, however if the user created a PCollection with Avro
> objects or IndexedRecord/GenericRecord, he needs to manually set the schema
> (or coder). The idea is to expose a method in schema.AvroUtils to ease this.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
