[ 
https://issues.apache.org/jira/browse/BEAM-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912631#comment-16912631
 ] 

Rahul Patwari commented on BEAM-6114:
-------------------------------------

I have asked a question in Calcite regarding the best practice to Implement our 
requirement. Here is the thread 
[link|[https://lists.apache.org/thread.html/023fe5e87d87a3405d8580e4adc93ca935f3aa4797119317ed016e9c@%3Cdev.calcite.apache.org%3E]].

It seems that they favor our current approach of identifying Join type in the 
expansion of PTransform.

> SQL join selection should be done in planner, not in expansion to PTransform
> ----------------------------------------------------------------------------
>
>                 Key: BEAM-6114
>                 URL: https://issues.apache.org/jira/browse/BEAM-6114
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Kenneth Knowles
>            Assignee: Rahul Patwari
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Currently Beam SQL joins all go through a single physical operator which has 
> a single PTransform that does all join algorithms based on properties of its 
> input PCollections as well as the relational algebra.
> A first step is to make the needed information part of the relational 
> algebra, so it can choose a PTransform based on that, and the PTransforms can 
> be simpler.
> Second step is to have separate (physical) relational operators for different 
> join algorithms.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to