[ https://issues.apache.org/jira/browse/BEAM-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913871#comment-16913871 ]
Rahul Patwari commented on BEAM-6114: ------------------------------------- Hi [~amaliujia] What are your thoughts about [https://github.com/apache/beam/blob/cacb9310b0223683ae6bea0637d2e0077ebee1de/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamSideInputLookupJoinRel.java#L52] I am planning to move Javadoc in [https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java] to the respective JoinRels. > SQL join selection should be done in planner, not in expansion to PTransform > ---------------------------------------------------------------------------- > > Key: BEAM-6114 > URL: https://issues.apache.org/jira/browse/BEAM-6114 > Project: Beam > Issue Type: Improvement > Components: dsl-sql > Reporter: Kenneth Knowles > Assignee: Rahul Patwari > Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently Beam SQL joins all go through a single physical operator which has > a single PTransform that does all join algorithms based on properties of its > input PCollections as well as the relational algebra. > A first step is to make the needed information part of the relational > algebra, so it can choose a PTransform based on that, and the PTransforms can > be simpler. > Second step is to have separate (physical) relational operators for different > join algorithms. -- This message was sent by Atlassian Jira (v8.3.2#803003)