[ https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302377 ]
ASF GitHub Bot logged work on BEAM-8021: ---------------------------------------- Author: ASF GitHub Bot Created on: 27/Aug/19 20:47 Start Date: 27/Aug/19 20:47 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #9417: [BEAM-8021] Add Automatic-Module-Name headers to beam's artifacts. URL: https://github.com/apache/beam/pull/9417#discussion_r318279275 ########## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ########## @@ -143,7 +161,25 @@ class BeamModulePlugin implements Plugin<Project> { List<String> shadowJarValidationExcludes = ["org/apache/beam/**"] /** Override the default "beam-" + `dash separated path` archivesBaseName. */ - String archivesBaseName = null; + String archivesBaseName = null + + /** + * Controls whether Automatic Module Header name should be set in MANIFEST.MF file. + * + * Set to false if a module should not have this header. It happens when we know for sure + * that a module should not be depended on. This includes the following cases: + * - a module contains documentation only (javadoc) + * - pure testing modules (e.g. "file-based-io-tests" module) + * - Apache Beam usage examples Review comment: add `Binaries such as the SQL shell` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 302377) Time Spent: 3h (was: 2h 50m) > Add Automatic-Module-Name headers for Beam Java modules > -------------------------------------------------------- > > Key: BEAM-8021 > URL: https://issues.apache.org/jira/browse/BEAM-8021 > Project: Beam > Issue Type: Sub-task > Components: build-system > Reporter: Ismaël Mejía > Assignee: Lukasz Gajowy > Priority: Minor > Time Spent: 3h > Remaining Estimate: 0h > > For compatibility with the Java Platform Module System (JPMS) in Java 9 and > later, every JAR should have a module name, even if the library does not > itself use modules. As [suggested in the mailing > list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E], > this is a simple change that we can do and still be backwards compatible. -- This message was sent by Atlassian Jira (v8.3.2#803003)