[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302395
]
ASF GitHub Bot logged work on BEAM-8021:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:47
Start Date: 27/Aug/19 20:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318285384
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -123,13 +123,31 @@ class BeamModulePlugin implements Plugin<Project> {
*
* The shadowJar / shadowTestJar tasks execute the specified closure to
configure themselves.
*/
- Closure shadowClosure;
+ Closure shadowClosure
/** Controls whether this project is published to Maven. */
boolean publish = true
/** Controls whether javadoc is exported for this project. */
boolean exportJavadoc = true
+
+ /**
+ * Controls whether Automatic Module Header name should be set in
MANIFEST.MF file.
+ *
+ * Set to false if a module should not have this header. It happens when
we know for sure
+ * that a module should not be depended on. This includes the following
cases:
+ * - a module contains documentation only (javadoc)
+ * - pure testing modules (e.g. "file-based-io-tests" module)
+ * - Apache Beam usage examples
+ */
Review comment:
add `Binaries such as the SQL shell`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 302395)
Time Spent: 5h 20m (was: 5h 10m)
> Add Automatic-Module-Name headers for Beam Java modules
> --------------------------------------------------------
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Ismaël Mejía
> Assignee: Lukasz Gajowy
> Priority: Minor
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
