[ 
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=305932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-305932
 ]

ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Sep/19 22:20
            Start Date: 03/Sep/19 22:20
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on pull request #9390: [BEAM-8019] 
Several changes to support cross-language transforms on DataflowRunner
URL: https://github.com/apache/beam/pull/9390#discussion_r320493505
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/core.py
 ##########
 @@ -325,10 +325,16 @@ def to_runner_api(self, context, has_parts=False):
       else:
         env1 = id_to_proto_map[env_id]
         env2 = context.environments[env_id]
-        assert env1.SerializeToString() == env2.SerializeToString(), (
+        assert env1.urn == env2.proto.urn, (
 
 Review comment:
   Why this change?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 305932)
    Time Spent: 40m  (was: 0.5h)

> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
>                 Key: BEAM-8019
>                 URL: https://issues.apache.org/jira/browse/BEAM-8019
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: Chamikara Jayalath
>            Assignee: Chamikara Jayalath
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to