[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=314054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314054
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Sep/19 23:40
Start Date: 17/Sep/19 23:40
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #9390:
[BEAM-8019] Several changes to support cross-language transforms on
DataflowRunner
URL: https://github.com/apache/beam/pull/9390#discussion_r325415730
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -917,8 +917,20 @@ def is_side_input(tag):
for tag, id in proto.outputs.items()}
# This annotation is expected by some runners.
if proto.spec.urn == common_urns.primitives.PAR_DO.urn:
- result.transform.output_tags = set(proto.outputs.keys()).difference(
- {'None'})
+ # Some external transforms require output tags to be not to be modified.
+ # So we randomly select one of the output tags as the main output and
+ # leave others as side outputs. Transform execution should not change
+ # dependending on which output tag we choose as the main output here.
+ from apache_beam.transforms.core import RunnerAPIPTransformHolder
+ external_transform = isinstance(result.transform,
+ RunnerAPIPTransformHolder)
+ main_output_tag = 'None' if not external_transform else \
Review comment:
Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 314054)
Time Spent: 1h (was: 50m)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Jayalath
> Assignee: Chamikara Jayalath
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
