[
https://issues.apache.org/jira/browse/BEAM-7969?focusedWorklogId=308130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308130
]
ASF GitHub Bot logged work on BEAM-7969:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/19 20:14
Start Date: 06/Sep/19 20:14
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #9494: [BEAM-7969]
Fix doublecount on GRPC PCollections in streaming jobs.
URL: https://github.com/apache/beam/pull/9494#discussion_r321893709
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
##########
@@ -400,13 +409,19 @@ void updateProgress() {
* @param monitoringInfos Usually received from FnApi.
*/
private void updateMetrics(List<MonitoringInfo> monitoringInfos) {
+ List<MonitoringInfo> monitoringInfosCopy = new
ArrayList<>(monitoringInfos);
+
+ List<MonitoringInfo> misToFilter =
+
bundleProcessOperation.findIOPCollectionMonitoringInfos(monitoringInfos);
Review comment:
findIOPCollectionMonitoringInfos
Could we use a better name here? Not sure what this is referring to. I
assume IO referrs to sources/sinks, but I don't think this is the case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 308130)
Time Spent: 6.5h (was: 6h 20m)
> Streaming Dataflow worker doesn't report FnAPI metrics.
> -------------------------------------------------------
>
> Key: BEAM-7969
> URL: https://issues.apache.org/jira/browse/BEAM-7969
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution, runner-dataflow
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> EOM
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
