[
https://issues.apache.org/jira/browse/BEAM-7969?focusedWorklogId=308134&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308134
]
ASF GitHub Bot logged work on BEAM-7969:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/19 20:22
Start Date: 06/Sep/19 20:22
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #9494: [BEAM-7969]
Fix doublecount on GRPC PCollections in streaming jobs.
URL: https://github.com/apache/beam/pull/9494#discussion_r321895776
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
##########
@@ -400,13 +409,19 @@ void updateProgress() {
* @param monitoringInfos Usually received from FnApi.
*/
private void updateMetrics(List<MonitoringInfo> monitoringInfos) {
+ List<MonitoringInfo> monitoringInfosCopy = new
ArrayList<>(monitoringInfos);
+
+ List<MonitoringInfo> misToFilter =
+
bundleProcessOperation.findIOPCollectionMonitoringInfos(monitoringInfos);
Review comment:
Is there a reason why we need to collect counters for these ones at all? Our
UI doesn't display the grpc steps, they are an implementation detail.
The alternative design I was thinking of here was to try and transform each
monitoring info, and drop the ones that do not have a step in the original
graph. Though, maybe there is no way to detect this? So they could be dropped
int the transformer, as there is no need to send them to DFE.
If I understand correctly, you are just avoiding a double count now? Though
I think we don't need to report these at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 308134)
Time Spent: 6h 40m (was: 6.5h)
> Streaming Dataflow worker doesn't report FnAPI metrics.
> -------------------------------------------------------
>
> Key: BEAM-7969
> URL: https://issues.apache.org/jira/browse/BEAM-7969
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution, runner-dataflow
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> EOM
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
