[
https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=319093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319093
]
ASF GitHub Bot logged work on BEAM-5428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/19 17:15
Start Date: 26/Sep/19 17:15
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9418: [BEAM-5428]
Implement cross-bundle user state caching in the Python SDK
URL: https://github.com/apache/beam/pull/9418#discussion_r328730529
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -1412,11 +1470,13 @@ def stop_worker(self):
class WorkerHandlerManager(object):
- def __init__(self, environments, job_provision_info):
+ def __init__(self, environments, job_provision_info, state_cache_size):
self._environments = environments
self._job_provision_info = job_provision_info
self._cached_handlers = collections.defaultdict(list)
- self._state = FnApiRunner.StateServicer() # rename?
+ self._state = sdk_worker.CachingMaterializingStateHandler(
+ StateCache(state_cache_size),
Review comment:
I added this because the WorkerHandlerManager will insert the state handler
into the WorkerHandlerFactory, which generates a cached BundleProcessorCache
with that state handler for the EmbeddedWorkerHandler. It is not necessary
otherwise and just does unnecessary caching on the FnApiRunner side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 319093)
Time Spent: 23h 40m (was: 23.5h)
> Implement cross-bundle state caching.
> -------------------------------------
>
> Key: BEAM-5428
> URL: https://issues.apache.org/jira/browse/BEAM-5428
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 23h 40m
> Remaining Estimate: 0h
>
> Tech spec:
> [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m]
> Relevant document:
> [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit]
> Mailing list link:
> [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
