[ https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=319572&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319572 ]
ASF GitHub Bot logged work on BEAM-5428: ---------------------------------------- Author: ASF GitHub Bot Created on: 27/Sep/19 14:08 Start Date: 27/Sep/19 14:08 Worklog Time Spent: 10m Work Description: mxm commented on pull request #9418: [BEAM-5428] Implement cross-bundle user state caching in the Python SDK URL: https://github.com/apache/beam/pull/9418#discussion_r329089645 ########## File path: sdks/python/apache_beam/runners/portability/portable_runner_test.py ########## @@ -201,7 +204,8 @@ class PortableRunnerTestWithExternalEnv(PortableRunnerTest): @classmethod def setUpClass(cls): cls._worker_address, cls._worker_server = ( - worker_pool_main.BeamFnExternalWorkerPoolServicer.start()) + worker_pool_main.BeamFnExternalWorkerPoolServicer.start( Review comment: Since this affects multiple parameters of the `start` method (e.g. `worker_threads`), I would handle this in a follow-up. It looks like either way, via individual parameters or via pipeline options here, there will be duplicate code paths, due to this method being used in a test context and for the main entry point in `if __name__ == '__main__'`. To fix this it would require restructuring of the entire file, which I see out of scope for this PR. But good to think about doing that eventually. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 319572) Time Spent: 24.5h (was: 24h 20m) > Implement cross-bundle state caching. > ------------------------------------- > > Key: BEAM-5428 > URL: https://issues.apache.org/jira/browse/BEAM-5428 > Project: Beam > Issue Type: Improvement > Components: sdk-py-harness > Reporter: Robert Bradshaw > Assignee: Maximilian Michels > Priority: Major > Time Spent: 24.5h > Remaining Estimate: 0h > > Tech spec: > [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m] > Relevant document: > [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit] > Mailing list link: > [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.4#803005)