[
https://issues.apache.org/jira/browse/BEAM-8365?focusedWorklogId=324672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324672
]
ASF GitHub Bot logged work on BEAM-8365:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/19 22:37
Start Date: 07/Oct/19 22:37
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9743: [BEAM-8365]
Project push-down for test table provider
URL: https://github.com/apache/beam/pull/9743#discussion_r332267954
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/test/TestTableProvider.java
##########
@@ -90,7 +94,38 @@ public void dropTable(String tableName) {
@Override
public synchronized BeamSqlTable buildBeamSqlTable(Table table) {
- return new InMemoryTable(tables().get(table.getName()));
+ BeamSqlTable beamSqlTable;
+
+ if (table.getProperties().containsKey(PUSH_DOWN)) {
Review comment:
It seems like table should have a property with if it supports PUSH_DOWN or
not? Why it can not be a filterable interface detection and has a
BeamIOFilterableSource?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 324672)
Time Spent: 0.5h (was: 20m)
> Add project push-down capability to IO APIs
> -------------------------------------------
>
> Key: BEAM-8365
> URL: https://issues.apache.org/jira/browse/BEAM-8365
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Kirill Kozlov
> Assignee: Kirill Kozlov
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> * Create a class extending InMemoryTable and implement a following method:
> {code:java}
> public PCollection<Row> buildIOReader(
> PBegin begin, BeamSqlTableFilter filters, List<String> fieldNames);{code}
> Which should return a `PCollection` with fields specified in `fieldNames`
> list.
> * Add a property "push_down" to TestTableProvider, which should allow user
> to select version of InMemoryProvider to use: with project push-down, with
> predicate push-down (will be implemented later), both (will be implemented
> later), or without (default).
> * Create a rule to push fields used by a Calc (in projects and in a
> condition) down into TestTable IO.
> * Updating that same Calc (from previous step) to have a proper input and
> output schemes, remove unused fields.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
