[
https://issues.apache.org/jira/browse/BEAM-8374?focusedWorklogId=327157&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327157
]
ASF GitHub Bot logged work on BEAM-8374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/19 00:02
Start Date: 12/Oct/19 00:02
Worklog Time Spent: 10m
Work Description: jfarr commented on pull request #9758: [BEAM-8374]
Fixes bug in SnsIO PublishResultCoder
URL: https://github.com/apache/beam/pull/9758#discussion_r334208170
##########
File path:
sdks/java/io/amazon-web-services/src/test/java/org/apache/beam/sdk/io/aws/sns/AmazonSNSMockSuccess.java
##########
@@ -29,10 +30,13 @@
@Override
public PublishResult publish(PublishRequest publishRequest) {
PublishResult result = Mockito.mock(PublishResult.class);
- SdkHttpMetadata metadata = Mockito.mock(SdkHttpMetadata.class);
- Mockito.when(metadata.getHttpHeaders()).thenReturn(new HashMap<>());
- Mockito.when(metadata.getHttpStatusCode()).thenReturn(200);
- Mockito.when(result.getSdkHttpMetadata()).thenReturn(metadata);
+ SdkHttpMetadata httpMetadata = Mockito.mock(SdkHttpMetadata.class);
Review comment:
Sure, I can make that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 327157)
Time Spent: 50m (was: 40m)
> PublishResult returned by SnsIO is missing sdkResponseMetadata and
> sdkHttpMetadata
> ----------------------------------------------------------------------------------
>
> Key: BEAM-8374
> URL: https://issues.apache.org/jira/browse/BEAM-8374
> Project: Beam
> Issue Type: Bug
> Components: io-java-aws
> Affects Versions: 2.13.0, 2.14.0, 2.15.0
> Reporter: Jonothan Farr
> Assignee: Jonothan Farr
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently the PublishResultCoder in SnsIO only serializes the messageId field
> so the PublishResult returned by Beam returns null for
> getSdkResponseMetadata() and getSdkHttpMetadata(). This makes it impossible
> to check the HTTP status for errors, which is necessary since this is not
> handled in SnsIO.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
