[
https://issues.apache.org/jira/browse/BEAM-8341?focusedWorklogId=330037&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330037
]
ASF GitHub Bot logged work on BEAM-8341:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/19 17:52
Start Date: 17/Oct/19 17:52
Worklog Time Spent: 10m
Work Description: xinyuiscool commented on pull request #9777:
[BEAM-8341]: basic bundling support for portable runner
URL: https://github.com/apache/beam/pull/9777#discussion_r336137794
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/DoFnOp.java
##########
@@ -237,9 +292,39 @@ private String getTimerStateId(DoFnSignature signature) {
return builder.toString();
}
+ private void attemptStartBundle() {
+ if (isBundleStarted.compareAndSet(false, true)) {
+ currentBundleElementCount.set(0L);
+ bundleStartTime.set(System.currentTimeMillis());
+ pushbackFnRunner.startBundle();
Review comment:
Shall we invoke scheduleNextBundleCheck() after startBundle()? Right now
schedule() is invoked in multiple places. Seems we only need to schedule the
check here all the time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 330037)
Time Spent: 40m (was: 0.5h)
> basic bundling support for samza portable runner
> ------------------------------------------------
>
> Key: BEAM-8341
> URL: https://issues.apache.org/jira/browse/BEAM-8341
> Project: Beam
> Issue Type: Task
> Components: runner-samza
> Reporter: Hai Lu
> Assignee: Hai Lu
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> bundling support for samza portable runner
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
