[
https://issues.apache.org/jira/browse/BEAM-8341?focusedWorklogId=330041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330041
]
ASF GitHub Bot logged work on BEAM-8341:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/19 17:52
Start Date: 17/Oct/19 17:52
Worklog Time Spent: 10m
Work Description: xinyuiscool commented on pull request #9777:
[BEAM-8341]: basic bundling support for portable runner
URL: https://github.com/apache/beam/pull/9777#discussion_r336141300
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SamzaDoFnRunners.java
##########
@@ -213,31 +218,65 @@ public void processElement(WindowedValue<InT> elem) {
}
};
- try (RemoteBundle bundle =
+ remoteBundle =
stageBundleFactory.getBundle(
receiverFactory,
StateRequestHandler.unsupported(),
- BundleProgressHandler.ignored())) {
-
Iterables.getOnlyElement(bundle.getInputReceivers().values()).accept(elem);
- }
+ BundleProgressHandler.ignored());
- // RemoteBundle close blocks until all results are received
- KV<String, FnOutT> result;
- while ((result = outputQueue.poll()) != null) {
- outputManager.output(
- idToTupleTagMap.get(result.getKey()), (WindowedValue)
result.getValue());
- }
+ inputReceiver =
Iterables.getOnlyElement(remoteBundle.getInputReceivers().values());
Review comment:
I guess this is to say we only support main output right now? Maybe worth a
comment for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 330041)
> basic bundling support for samza portable runner
> ------------------------------------------------
>
> Key: BEAM-8341
> URL: https://issues.apache.org/jira/browse/BEAM-8341
> Project: Beam
> Issue Type: Task
> Components: runner-samza
> Reporter: Hai Lu
> Assignee: Hai Lu
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> bundling support for samza portable runner
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
