[
https://issues.apache.org/jira/browse/BEAM-8382?focusedWorklogId=339698&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339698
]
ASF GitHub Bot logged work on BEAM-8382:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/19 02:14
Start Date: 07/Nov/19 02:14
Worklog Time Spent: 10m
Work Description: jfarr commented on pull request #9765: [WIP][BEAM-8382]
Add rate limit policy to KinesisIO.Read
URL: https://github.com/apache/beam/pull/9765#discussion_r343429384
##########
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/ShardReadersPool.java
##########
@@ -149,10 +157,20 @@ private void readLoop(ShardRecordsIterator
shardRecordsIterator) {
recordsQueue.put(kinesisRecord);
numberOfRecordsInAQueueByShard.get(kinesisRecord.getShardId()).incrementAndGet();
}
+ rateLimiter.onSuccess(kinesisRecords);
+ } catch (KinesisClientThrottledException e) {
+ try {
+ rateLimiter.onThrottle(e);
+ } catch (InterruptedException ex) {
+ LOG.warn("Thread was interrupted, finishing the read loop", ex);
+ Thread.currentThread().interrupt();
Review comment:
Thread.interrupt() does not interrupt the current thread, it sets the
thread's interrupt status. The short answer is that catching
InterruptedException clears the interrupt status so in order to handle it
properly you should always either rethrow the exception or reset the thread's
interrupt status so any code higher up the call stack can still detect the
interruption. There is a good article by Brian Goetz that goes into the
details: https://www.ibm.com/developerworks/java/library/j-jtp05236/index.html.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 339698)
Time Spent: 9.5h (was: 9h 20m)
> Add polling interval to KinesisIO.Read
> --------------------------------------
>
> Key: BEAM-8382
> URL: https://issues.apache.org/jira/browse/BEAM-8382
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kinesis
> Affects Versions: 2.13.0, 2.14.0, 2.15.0
> Reporter: Jonothan Farr
> Assignee: Jonothan Farr
> Priority: Major
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> With the current implementation we are observing Kinesis throttling due to
> ReadProvisionedThroughputExceeded on the order of hundreds of times per
> second, regardless of the actual Kinesis throughput. This is because the
> ShardReadersPool readLoop() method is polling getRecords() as fast as
> possible.
> From the KDS documentation:
> {quote}Each shard can support up to five read transactions per second.
> {quote}
> and
> {quote}For best results, sleep for at least 1 second (1,000 milliseconds)
> between calls to getRecords to avoid exceeding the limit on getRecords
> frequency.
> {quote}
> [https://docs.aws.amazon.com/streams/latest/dev/service-sizes-and-limits.html]
> [https://docs.aws.amazon.com/streams/latest/dev/developing-consumers-with-sdk.html]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
