[
https://issues.apache.org/jira/browse/BEAM-8382?focusedWorklogId=339867&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339867
]
ASF GitHub Bot logged work on BEAM-8382:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/19 10:44
Start Date: 07/Nov/19 10:44
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9765:
[WIP][BEAM-8382] Add rate limit policy to KinesisIO.Read
URL: https://github.com/apache/beam/pull/9765#issuecomment-551024704
@cmachgodaddy
> #2 Of course, we can add a ton of checkers, but users will be confuse of
which one of withRateLimitXXXs to use. I would rather have just one
withRateLimitXXX and let user pass in an Enum.
We already have the similar API for watermarks factory in KinesisIO, so I
think it will make sense to keep the same style here. And I don't think users
will be very confused if we have clear Java doc for each method and examples of
usage in the class Java doc. New checks are actually not needed, they could
just prevent users from potential mistakes.
@jfarr
> I'm not sure if RetryPolicy and BackoffStrategy apply to
LimitExceededException / ProvisionedThroughputExceededException but I can look
into that. If so I think it makes sense to just configure this in the Kinesis
client instead of having a BackoffRateLimitPolicy.
I'm ok with that if it won't fail a pipeline in case of throttling and work
in the similar way as FluentBackoff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 339867)
Time Spent: 10h 10m (was: 10h)
> Add polling interval to KinesisIO.Read
> --------------------------------------
>
> Key: BEAM-8382
> URL: https://issues.apache.org/jira/browse/BEAM-8382
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kinesis
> Affects Versions: 2.13.0, 2.14.0, 2.15.0
> Reporter: Jonothan Farr
> Assignee: Jonothan Farr
> Priority: Major
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
> With the current implementation we are observing Kinesis throttling due to
> ReadProvisionedThroughputExceeded on the order of hundreds of times per
> second, regardless of the actual Kinesis throughput. This is because the
> ShardReadersPool readLoop() method is polling getRecords() as fast as
> possible.
> From the KDS documentation:
> {quote}Each shard can support up to five read transactions per second.
> {quote}
> and
> {quote}For best results, sleep for at least 1 second (1,000 milliseconds)
> between calls to getRecords to avoid exceeding the limit on getRecords
> frequency.
> {quote}
> [https://docs.aws.amazon.com/streams/latest/dev/service-sizes-and-limits.html]
> [https://docs.aws.amazon.com/streams/latest/dev/developing-consumers-with-sdk.html]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
