[ https://issues.apache.org/jira/browse/BEAM-8802?focusedWorklogId=347764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347764 ]
ASF GitHub Bot logged work on BEAM-8802: ---------------------------------------- Author: ASF GitHub Bot Created on: 21/Nov/19 22:43 Start Date: 21/Nov/19 22:43 Worklog Time Spent: 10m Work Description: HuangLED commented on pull request #10191: [BEAM-8802] Don't clear watermark hold when adding elements. URL: https://github.com/apache/beam/pull/10191#discussion_r349355630 ########## File path: sdks/python/apache_beam/transforms/timeutil.py ########## @@ -64,19 +64,19 @@ class TimestampCombinerImpl(with_metaclass(ABCMeta, object)): @abstractmethod def assign_output_time(self, window, input_timestamp): - pass + raise NotImplementedError @abstractmethod def combine(self, output_timestamp, other_output_timestamp): - pass + raise NotImplementedError def combine_all(self, merging_timestamps): """Apply combine to list of timestamps.""" combined_output_time = None for output_time in merging_timestamps: if combined_output_time is None: combined_output_time = output_time - else: + elif output_time is not None: combined_output_time = self.combine( combined_output_time, output_time) Review comment: what would be the "else" after this change, and what would it imply when this happens? Shall we at least log something when fall into that situation? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 347764) Time Spent: 40m (was: 0.5h) > Timestamp combiner not respected across bundles in streaming mode. > ------------------------------------------------------------------ > > Key: BEAM-8802 > URL: https://issues.apache.org/jira/browse/BEAM-8802 > Project: Beam > Issue Type: Bug > Components: sdk-py-core > Reporter: Robert Bradshaw > Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)