[
https://issues.apache.org/jira/browse/BEAM-8802?focusedWorklogId=348278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348278
]
ASF GitHub Bot logged work on BEAM-8802:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 19:10
Start Date: 22/Nov/19 19:10
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10191: [BEAM-8802]
Don't clear watermark hold when adding elements.
URL: https://github.com/apache/beam/pull/10191#discussion_r349750760
##########
File path: sdks/python/apache_beam/transforms/timeutil.py
##########
@@ -64,19 +64,19 @@ class TimestampCombinerImpl(with_metaclass(ABCMeta,
object)):
@abstractmethod
def assign_output_time(self, window, input_timestamp):
- pass
+ raise NotImplementedError
@abstractmethod
def combine(self, output_timestamp, other_output_timestamp):
- pass
+ raise NotImplementedError
def combine_all(self, merging_timestamps):
"""Apply combine to list of timestamps."""
combined_output_time = None
for output_time in merging_timestamps:
if combined_output_time is None:
combined_output_time = output_time
- else:
+ elif output_time is not None:
combined_output_time = self.combine(
combined_output_time, output_time)
Review comment:
Currently the code can handle `None`s up until the first non-None value, and
not after that. This makes it more consistent by allowing any values to be
`None`. The else is to go onto the next value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 348278)
Time Spent: 1h (was: 50m)
> Timestamp combiner not respected across bundles in streaming mode.
> ------------------------------------------------------------------
>
> Key: BEAM-8802
> URL: https://issues.apache.org/jira/browse/BEAM-8802
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
