[
https://issues.apache.org/jira/browse/BEAM-4776?focusedWorklogId=348003&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348003
]
ASF GitHub Bot logged work on BEAM-4776:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 08:43
Start Date: 22/Nov/19 08:43
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #10105: [BEAM-4776]
Add metrics support to Java PortableRunner
URL: https://github.com/apache/beam/pull/10105#discussion_r349483248
##########
File path: runners/flink/job-server/flink_job_server.gradle
##########
@@ -139,12 +139,9 @@ def portableValidatesRunnerTask(String name, Boolean
streaming) {
includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
excludeCategories
'org.apache.beam.sdk.testing.FlattenWithHeterogeneousCoders'
excludeCategories 'org.apache.beam.sdk.testing.LargeKeys$Above100MB'
- excludeCategories 'org.apache.beam.sdk.testing.UsesAttemptedMetrics'
Review comment:
Not a blocker for this PR but out of curiosity, do enabling these in the
Portable Spark Runner pass? It would be a good idea to enable it to if so, or
report the errors so they can be fixed if not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 348003)
Time Spent: 6h 10m (was: 6h)
> Java PortableRunner should support metrics
> ------------------------------------------
>
> Key: BEAM-4776
> URL: https://issues.apache.org/jira/browse/BEAM-4776
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Eugene Kirpichov
> Assignee: Michal Walenia
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> BEAM-4775 concerns adding metrics to the JobService API; the current issue is
> about making PortableRunner understand them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
