[ https://issues.apache.org/jira/browse/BEAM-4776?focusedWorklogId=349797&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349797 ]
ASF GitHub Bot logged work on BEAM-4776: ---------------------------------------- Author: ASF GitHub Bot Created on: 26/Nov/19 14:02 Start Date: 26/Nov/19 14:02 Worklog Time Spent: 10m Work Description: echauchot commented on issue #10105: [BEAM-4776] Add metrics support to Java PortableRunner URL: https://github.com/apache/beam/pull/10105#issuecomment-558642246 @mwalenia to answer your question, I'm indeed the correct person for MetricsPusher related questions. Regarding MetricsPusher, the problem goes beyond the test itself. The whole MetricsPusher feature reports for now only user metrics (that is why the test sink that is tailored for it only reads user metrics). But the aim since the beginning of the architectural design (pull vs push essentially) was to allow in the future to support system metrics. Here is the design I did at the time: https://s.apache.org/runner_independent_metrics_extraction. Long story short, the good thing to do IMHO is to enhance MetricsPusher to support system metrics as well and, of course, update the test/sink. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 349797) Time Spent: 7.5h (was: 7h 20m) > Java PortableRunner should support metrics > ------------------------------------------ > > Key: BEAM-4776 > URL: https://issues.apache.org/jira/browse/BEAM-4776 > Project: Beam > Issue Type: Bug > Components: runner-core > Reporter: Eugene Kirpichov > Assignee: Michal Walenia > Priority: Major > Time Spent: 7.5h > Remaining Estimate: 0h > > BEAM-4775 concerns adding metrics to the JobService API; the current issue is > about making PortableRunner understand them. -- This message was sent by Atlassian Jira (v8.3.4#803005)