[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=348316&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348316
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 19:41
Start Date: 22/Nov/19 19:41
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #9915: [BEAM-7746]
Add python type hints (part 1)
URL: https://github.com/apache/beam/pull/9915#discussion_r349757301
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -367,7 +381,10 @@ class FixedWindows(NonMergingWindowFn):
range.
"""
- def __init__(self, size, offset=0):
+ def __init__(self,
+ size, # type: Union[int, float, Duration]
Review comment:
Maybe make this into a named type? (Similarly for the Timestamp one.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 348316)
Time Spent: 28h 10m (was: 28h)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 28h 10m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
