[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=348320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348320
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 19:41
Start Date: 22/Nov/19 19:41
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #9915: [BEAM-7746]
Add python type hints (part 1)
URL: https://github.com/apache/beam/pull/9915#discussion_r349762313
##########
File path: sdks/python/setup.py
##########
@@ -25,20 +25,52 @@
import sys
import warnings
from distutils import log
+from distutils.errors import DistutilsError
from distutils.version import StrictVersion
# Pylint and isort disagree here.
# pylint: disable=ungrouped-imports
import setuptools
from pkg_resources import DistributionNotFound
from pkg_resources import get_distribution
+from pkg_resources import normalize_path
+from pkg_resources import to_filename
+from setuptools import Command
from setuptools.command.build_py import build_py
-# TODO: (BEAM-8411): re-enable lint check.
-from setuptools.command.develop import develop # pylint: disable-all
+from setuptools.command.develop import develop
from setuptools.command.egg_info import egg_info
from setuptools.command.test import test
+class mypy(Command):
+ user_options = []
+
+ def initialize_options(self):
+ """Abstract method that is required to be overwritten"""
+
+ def finalize_options(self):
+ """Abstract method that is required to be overwritten"""
+
+ def get_project_path(self):
+ self.run_command('egg_info')
+
+ # Build extensions in-place
+ self.reinitialize_command('build_ext', inplace=1)
+ self.run_command('build_ext')
+
+ ei_cmd = self.get_finalized_command("egg_info")
+
+ project_path = normalize_path(ei_cmd.egg_base)
+ return os.path.join(project_path, to_filename(ei_cmd.egg_name))
+
+ def run(self):
+ import subprocess
+ args = ['mypy', self.get_project_path()]
+ result = subprocess.call(args)
+ if result != 0:
+ raise DistutilsError()
Review comment:
No message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 348320)
Time Spent: 28h 50m (was: 28h 40m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 28h 50m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
