[
https://issues.apache.org/jira/browse/BEAM-8824?focusedWorklogId=352245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352245
]
ASF GitHub Bot logged work on BEAM-8824:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/19 21:52
Start Date: 02/Dec/19 21:52
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10216: [BEAM-8824]
Add support to allow specify window allowed_lateness in python sdk
URL: https://github.com/apache/beam/pull/10216#discussion_r352874522
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -2235,7 +2235,20 @@ def expand(self, pcoll):
class Windowing(object):
def __init__(self, windowfn, triggerfn=None, accumulation_mode=None,
- timestamp_combiner=None):
+ timestamp_combiner=None, allowed_lateness=0):
+ """Class representing the window strategy.
+
+ Args:
+ windowfn: Window assign function.
+ triggerfn: Trigger function.
+ accumulation_mode: a AccumulationMode, controls what to do with data
+ when a trigger fires multiple times.
+ timestamp_combiner: a TimestampCombiner, determines how output
+ timestamps of grouping operations are assigned.
+ allowed_lateness(int): Maximum delay in seconds after end of window
Review comment:
Nit: I'd cut the (int) for consistency. Technically we should accept floats
here as well, and possibly convert to Durations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 352245)
Time Spent: 2h 40m (was: 2.5h)
> Add support for allowed lateness in python sdk
> ----------------------------------------------
>
> Key: BEAM-8824
> URL: https://issues.apache.org/jira/browse/BEAM-8824
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
