[
https://issues.apache.org/jira/browse/BEAM-8824?focusedWorklogId=352247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352247
]
ASF GitHub Bot logged work on BEAM-8824:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/19 21:52
Start Date: 02/Dec/19 21:52
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10216: [BEAM-8824]
Add support to allow specify window allowed_lateness in python sdk
URL: https://github.com/apache/beam/pull/10216#discussion_r352875296
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -2315,7 +2331,8 @@ def from_runner_api(proto, context):
windowfn=WindowFn.from_runner_api(proto.window_fn, context),
triggerfn=TriggerFn.from_runner_api(proto.trigger, context),
accumulation_mode=proto.accumulation_mode,
- timestamp_combiner=proto.output_time)
+ timestamp_combiner=proto.output_time,
+ allowed_lateness=proto.allowed_lateness // 1000)
Review comment:
This is lossy, and it's possible that this comes from other languages that
support sub-second allowed lateness.
`Duration(micros=proto.allowed_lateness * 1000)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 352247)
> Add support for allowed lateness in python sdk
> ----------------------------------------------
>
> Key: BEAM-8824
> URL: https://issues.apache.org/jira/browse/BEAM-8824
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
