[
https://issues.apache.org/jira/browse/BEAM-5495?focusedWorklogId=354167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-354167
]
ASF GitHub Bot logged work on BEAM-5495:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/19 10:05
Start Date: 05/Dec/19 10:05
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #10268: [BEAM-5495]
PipelineResources algorithm is not working in most environments
URL: https://github.com/apache/beam/pull/10268#discussion_r354211593
##########
File path:
.test-infra/jenkins/job_PostCommit_Java_ValidatesRunner_Dataflow_Java11.groovy
##########
@@ -19,9 +19,11 @@
import CommonJobProperties as commonJobProperties
import PostcommitJobBuilder
+final String JAVA_11_HOME = '/usr/lib/jvm/java-11-openjdk-amd64'
+final String JAVA_8_HOME = '/usr/lib/jvm/java-8-openjdk-amd64'
PostcommitJobBuilder.postCommitJob('beam_PostCommit_Java11_ValidatesRunner_Dataflow',
- 'Run Dataflow ValidatesRunner Java 11', 'Google Cloud Dataflow Runner
ValidatesRunner Tests On Java 11', this) {
+ 'Run Dataflow ValidatesRunner Java 11', 'Google Cloud Dataflow Runner
ValidatesRunner Tests On Java 11', this) {
Review comment:
I'm not sure if I understand you - we're using the
PostcommitJobBuilder.postCommitJob() method here. It creates 2 jobs:
- "beam_PostCommit_Java11_ValidatesRunner_Dataflow"
- "beam_PostCommit_Java11_ValidatesRunner_Dataflow_PR" (the suffix is added
automatically by the builder - there's no way to modify it if you're using the
builder)
What do you mean by "job title"? Do you mean the "name"? or the
"triggerPhrase" or "githubUIHint" in the
[postCommitJob](https://github.com/apache/beam/blob/master/.test-infra/jenkins/PostcommitJobBuilder.groovy#L47)
method? In your opinion, should I separate the creation of the two jobs and
have custom configurations (including naming) for the two?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 354167)
Time Spent: 4h 40m (was: 4.5h)
> PipelineResources algorithm is not working in most environments
> ---------------------------------------------------------------
>
> Key: BEAM-5495
> URL: https://issues.apache.org/jira/browse/BEAM-5495
> Project: Beam
> Issue Type: Bug
> Components: runner-flink, runner-spark, sdk-java-core
> Reporter: Romain Manni-Bucau
> Assignee: Lukasz Gajowy
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Issue are:
> 1. it assumes the classloader is an URLClassLoader (not always true and java
> >= 9 breaks that as well for the app loader)
> 2. it uses loader.getURLs() which leads to including the JRE itself in the
> staged file
> Looks like this detect resource algorithm can't work and should be replaced
> by a SPI rather than a built-in and not extensible algorithm. Another valid
> alternative is to just drop that "guess" logic and force the user to set
> staged files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
