[
https://issues.apache.org/jira/browse/BEAM-5495?focusedWorklogId=354172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-354172
]
ASF GitHub Bot logged work on BEAM-5495:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/19 10:24
Start Date: 05/Dec/19 10:24
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #10268: [BEAM-5495]
PipelineResources algorithm is not working in most environments
URL: https://github.com/apache/beam/pull/10268#discussion_r354221674
##########
File path:
.test-infra/jenkins/job_PostCommit_Java_ValidatesRunner_Dataflow_Java11.groovy
##########
@@ -19,9 +19,11 @@
import CommonJobProperties as commonJobProperties
import PostcommitJobBuilder
+final String JAVA_11_HOME = '/usr/lib/jvm/java-11-openjdk-amd64'
+final String JAVA_8_HOME = '/usr/lib/jvm/java-8-openjdk-amd64'
Review comment:
Good point - I agree. This was copied from some other job
([VR_Direct_Java11](https://github.com/apache/beam/blob/fa37fc5e176e72fd346b9a0bb907d9726b33d018/.test-infra/jenkins/job_PostCommit_Java_ValidatesRunner_Direct_Java11.groovy)).
If I'm not mistaken, adding new env variables to Jenkins has to go through
asf infra so that they add the variables and then we can easily use them. Am I
right @Ardagan ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 354172)
Time Spent: 5h (was: 4h 50m)
> PipelineResources algorithm is not working in most environments
> ---------------------------------------------------------------
>
> Key: BEAM-5495
> URL: https://issues.apache.org/jira/browse/BEAM-5495
> Project: Beam
> Issue Type: Bug
> Components: runner-flink, runner-spark, sdk-java-core
> Reporter: Romain Manni-Bucau
> Assignee: Lukasz Gajowy
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Issue are:
> 1. it assumes the classloader is an URLClassLoader (not always true and java
> >= 9 breaks that as well for the app loader)
> 2. it uses loader.getURLs() which leads to including the JRE itself in the
> staged file
> Looks like this detect resource algorithm can't work and should be replaced
> by a SPI rather than a built-in and not extensible algorithm. Another valid
> alternative is to just drop that "guess" logic and force the user to set
> staged files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
