[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=359653&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359653
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/19 21:13
Start Date: 13/Dec/19 21:13
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #9915: [BEAM-7746] Add
python type hints (part 1)
URL: https://github.com/apache/beam/pull/9915#issuecomment-565610604
Is that not part of the precommit suite? The tests for this PR definitely
ran and passed. The traceback seemed to indicate that google.protobuf is
not installed...
On Fri, Dec 13, 2019 at 11:31 AM Udi Meiri <notificati...@github.com> wrote:
> I believe this PR broke
> :sdks:python:test-suites:direct:py37:hdfsIntegrationTest
> Opened https://issues.apache.org/jira/browse/BEAM-8966
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/9915?email_source=notifications&email_token=AAAPOE3TOM63EE2P72YWOTTQYPPHNA5CNFSM4JGC3N42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG3AO5Y#issuecomment-565577591>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAAPOE3HEVMZEZOXV2MHHM3QYPPHNANCNFSM4JGC3N4Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 359653)
Time Spent: 36h (was: 35h 50m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 36h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
