[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=368518&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368518
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 00:31
Start Date: 09/Jan/20 00:31
Worklog Time Spent: 10m
Work Description: udim commented on pull request #10367: [BEAM-7746] Add
python type hints (part 2)
URL: https://github.com/apache/beam/pull/10367#discussion_r364501015
##########
File path: sdks/python/apache_beam/runners/common.py
##########
@@ -793,6 +804,8 @@ def current_element_progress(self):
restriction_tracker = self.threadsafe_restriction_tracker
if restriction_tracker:
return restriction_tracker.current_progress()
+ else:
+ return None
Review comment:
Again, isn't this redundant? Does mypy require it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 368518)
Time Spent: 37h 50m (was: 37h 40m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 37h 50m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
