[
https://issues.apache.org/jira/browse/BEAM-8630?focusedWorklogId=362663&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362663
]
ASF GitHub Bot logged work on BEAM-8630:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 19:11
Start Date: 23/Dec/19 19:11
Worklog Time Spent: 10m
Work Description: robinyqiu commented on pull request #9913: [BEAM-8630]
Prototype of BeamZetaSqlCalcRel
URL: https://github.com/apache/beam/pull/9913#discussion_r360977978
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SingleRowScanConverter.java
##########
@@ -36,6 +42,22 @@ public boolean canConvert(ResolvedSingleRowScan zetaNode) {
@Override
public RelNode convert(ResolvedSingleRowScan zetaNode, List<RelNode> inputs)
{
- return LogicalValues.createOneRow(getCluster());
+ return createOneRow(getCluster());
+ }
+
+ // This function is a reimplementation of Calcite's
LogicalValues.createOneRow() with a single
+ // line change: SqlTypeName.INTEGER replaced by SqlTypeName.BIGINT.
+ // Would like to use LogicalValues.createOneRow(), but it uses type
SqlTypeName.INTEGER which
+ // correspond to TypeKind.TYPE_INT32 in ZetaSQL, a type not supported in
PRODUCT_EXTERNAL mode.
+ private static LogicalValues createOneRow(RelOptCluster cluster) {
Review comment:
Added more context in the comments. Please let me know if this makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 362663)
Time Spent: 3h 50m (was: 3h 40m)
> Prototype of BeamSQL Calc using ZetaSQL Expression Evaluator
> ------------------------------------------------------------
>
> Key: BEAM-8630
> URL: https://issues.apache.org/jira/browse/BEAM-8630
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
