[
https://issues.apache.org/jira/browse/BEAM-8630?focusedWorklogId=362774&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362774
]
ASF GitHub Bot logged work on BEAM-8630:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 22:32
Start Date: 23/Dec/19 22:32
Worklog Time Spent: 10m
Work Description: robinyqiu commented on pull request #9913: [BEAM-8630]
Prototype of BeamZetaSqlCalcRel
URL: https://github.com/apache/beam/pull/9913#discussion_r361017315
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -64,6 +68,28 @@ public ZetaSQLQueryPlanner(JdbcConnection jdbcConnection,
RuleSet[] ruleSets) {
plannerImpl = new ZetaSQLPlannerImpl(defaultConfig(jdbcConnection,
ruleSets));
}
+ public static RuleSet[] getZetaSqlRuleSets() {
+ // TODO[BEAM-8630]: uncomment the next line once we have fully migrated to
BeamZetaSqlCalcRel
+ // return replaceBeamCalcRule(BeamRuleSets.getRuleSets());
Review comment:
Ah I see what you are saying. The constructor above is called reflectively
in `BeamSqlEnv`:
https://github.com/apache/beam/blob/fd817c7c27e4ffed90f368e0ebfa2ef8e38f45a9/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamSqlEnv.java#L310
so we do need to make some change when we want to turn it on. Added some
commented-out code for this purpose (I am pretty sure there will be better ways
to do this, but let's keep it as it is for now).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 362774)
Time Spent: 5h 20m (was: 5h 10m)
> Prototype of BeamSQL Calc using ZetaSQL Expression Evaluator
> ------------------------------------------------------------
>
> Key: BEAM-8630
> URL: https://issues.apache.org/jira/browse/BEAM-8630
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
