[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=368537&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368537
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 00:56
Start Date: 09/Jan/20 00:56
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10367: [BEAM-7746]
Add python type hints (part 2)
URL: https://github.com/apache/beam/pull/10367#discussion_r364516322
##########
File path: sdks/python/gen_protos.py
##########
@@ -47,6 +50,164 @@
]
+def generate_urn_files(log, out_dir):
Review comment:
Here is `beam_job_api_pb2_urn.py`:
```python
from builtins import object
from .. import PropertiesFromEnumValue
from . import metrics_pb2
EMPTY_MONITORING_INFO_LABEL_PROPS = metrics_pb2.MonitoringInfoLabelProps()
EMPTY_MONITORING_INFO_SPEC = metrics_pb2.MonitoringInfoSpec()
class JobMessage(object):
class MessageImportance(object):
MESSAGE_IMPORTANCE_UNSPECIFIED = PropertiesFromEnumValue(u'', u'',
EMPTY_MONITORING_INFO_SPEC, EMPTY_MONITORING_INFO_LABEL_PROPS)
JOB_MESSAGE_DEBUG = PropertiesFromEnumValue(u'', u'',
EMPTY_MONITORING_INFO_SPEC, EMPTY_MONITORING_INFO_LABEL_PROPS)
JOB_MESSAGE_DETAILED = PropertiesFromEnumValue(u'', u'',
EMPTY_MONITORING_INFO_SPEC, EMPTY_MONITORING_INFO_LABEL_PROPS)
JOB_MESSAGE_BASIC = PropertiesFromEnumValue(u'', u'',
EMPTY_MONITORING_INFO_SPEC, EMPTY_MONITORING_INFO_LABEL_PROPS)
JOB_MESSAGE_WARNING = PropertiesFromEnumValue(u'', u'',
EMPTY_MONITORING_INFO_SPEC, EMPTY_MONITORING_INFO_LABEL_PROPS)
JOB_MESSAGE_ERROR = PropertiesFromEnumValue(u'', u'',
EMPTY_MONITORING_INFO_SPEC, EMPTY_MONITORING_INFO_LABEL_PROPS)
class JobState(object):
class Enum(object):
UNSPECIFIED = PropertiesFromEnumValue(u'', u'',
EMPTY_MONITORING_INFO_SPEC, EMPTY_MONITORING_INFO_LABEL_PROPS)
STOPPED = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
RUNNING = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
DONE = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
FAILED = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
CANCELLED = PropertiesFromEnumValue(u'', u'',
EMPTY_MONITORING_INFO_SPEC, EMPTY_MONITORING_INFO_LABEL_PROPS)
UPDATED = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
DRAINING = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
DRAINED = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
STARTING = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
CANCELLING = PropertiesFromEnumValue(u'', u'',
EMPTY_MONITORING_INFO_SPEC, EMPTY_MONITORING_INFO_LABEL_PROPS)
UPDATING = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
class PipelineOptionType(object):
class Enum(object):
STRING = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
BOOLEAN = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
INTEGER = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
NUMBER = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
ARRAY = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
OBJECT = PropertiesFromEnumValue(u'', u'', EMPTY_MONITORING_INFO_SPEC,
EMPTY_MONITORING_INFO_LABEL_PROPS)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 368537)
Time Spent: 38h (was: 37h 50m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 38h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
