[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=368764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368764
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 02:13
Start Date: 09/Jan/20 02:13
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10367: [BEAM-7746]
Add python type hints (part 2)
URL: https://github.com/apache/beam/pull/10367#discussion_r364531963
##########
File path: sdks/python/apache_beam/pvalue.py
##########
@@ -82,7 +82,7 @@ class PValue(object):
"""
def __init__(self,
- pipeline, # type: Pipeline
+ pipeline, # type: Optional[Pipeline]
Review comment:
Yes, here:
```python
class PCollection(PValue, Generic[T]):
[...]
@staticmethod
def from_runner_api(proto, context):
# type: (beam_runner_api_pb2.PCollection, PipelineContext) -> PCollection
# Producer and tag will be filled in later, the key point is that the
# same object is returned for the same pcollection id.
return PCollection(
None,
element_type=context.element_type_from_coder_id(proto.coder_id),
windowing=context.windowing_strategies.get_by_id(
proto.windowing_strategy_id),
is_bounded=proto.is_bounded == beam_runner_api_pb2.IsBounded.BOUNDED)
```
It would be nice if we could get rid of this case somehow, because by making
this optional we have to deal with the possibility of `pvalue.pipeline` being
`None` throughout the code base. I went back and forth on whether to make the
arg optional or simply ignore the error in the method above, but I think I
decided that the method above was a common case and thus we needed the
protection against None-values throughout the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 368764)
Time Spent: 39h 20m (was: 39h 10m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 39h 20m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
