[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=369522&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369522
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/20 01:28
Start Date: 10/Jan/20 01:28
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10367: [BEAM-7746]
Add python type hints (part 2)
URL: https://github.com/apache/beam/pull/10367#discussion_r365037593
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -1130,19 +1132,26 @@ def process(self, windowed_value):
@BeamTransformFactory.register_urn(
DATA_INPUT_URN, beam_fn_api_pb2.RemoteGrpcPort)
-def create(factory, transform_id, transform_proto, grpc_port, consumers):
+def create_source_runner(
Review comment:
I think the best way to reduce the noise here would be make the registration
more object oriented.
Quick sketch:
```python
class OpCreator(Generic[OperatorT]):
def __init__(
self,
factory, # type: BeamTransformFactory
transform_id, # type: str
transform_proto, # type: beam_runner_api_pb2.PTransform
consumers # type: Dict[str, List[operations.Operation]]
):
self.factory = factory
self.transform_id = transform_id
self.transform_proto = transform_proto
self.consumers = consumers
def create(self, parameter):
# type: (Any) -> OperatorT
raise NotImplementedError
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 369522)
Time Spent: 44h 50m (was: 44h 40m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 44h 50m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
