[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=369527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369527
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/20 01:35
Start Date: 10/Jan/20 01:35
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10367: [BEAM-7746]
Add python type hints (part 2)
URL: https://github.com/apache/beam/pull/10367#discussion_r365039017
##########
File path: sdks/python/apache_beam/transforms/environments.py
##########
@@ -55,12 +74,52 @@ class Environment(object):
For internal use only. No backwards compatibility guarantees.
"""
- _known_urns = {}
- _urn_to_env_cls = {}
+ _known_urns = {} # type: Dict[str, Tuple[Optional[type], ConstructorFn]]
+ _urn_to_env_cls = {} # type: Dict[str, type]
def to_runner_api_parameter(self, context):
+ # type: (PipelineContext) -> Tuple[str, Optional[Union[message.Message,
bytes, str]]]
raise NotImplementedError
+
+ @classmethod
+ @overload
+ def register_urn(cls,
+ urn, # type: str
+ parameter_type, # type: Type[T]
+ ):
+ # type: (...) -> Callable[[Union[type, Callable[[T, PipelineContext],
Any]]], Callable[[T, PipelineContext], Any]]
+ pass
+
+ @classmethod
+ @overload
+ def register_urn(cls,
+ urn, # type: str
+ parameter_type, # type: None
Review comment:
that would be nice from a typing simplicity standpoint. not sure about the
implications of that though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 369527)
Time Spent: 45h 20m (was: 45h 10m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 45h 20m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
