[
https://issues.apache.org/jira/browse/BEAM-8933?focusedWorklogId=371948&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371948
]
ASF GitHub Bot logged work on BEAM-8933:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/20 23:05
Start Date: 14/Jan/20 23:05
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10369:
[BEAM-8933] BigQueryIO Arrow for read
URL: https://github.com/apache/beam/pull/10369#discussion_r366619603
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageQuerySource.java
##########
@@ -57,6 +59,32 @@
priority,
location,
kmsKey,
+ format,
+ parseFn,
+ outputCoder,
+ bqServices);
+ }
+
+ public static <T> BigQueryStorageQuerySource<T> create(
Review comment:
+1 for making this entire source non-public unless we actually intend for
users to create one themselves.
It seems like there is some precedent for making BoundedSource
implementations public (AvroSource,
ElasticSearchIO.BoundedElasticsearchSource), but maybe that's something that
should be cleaned up.
In the elasticsearch case at least the source is annotated
VisibleForTesting, but all the tests are in the same package, so I don't think
this is necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 371948)
Time Spent: 7h 10m (was: 7h)
> BigQuery IO should support read/write in Arrow format
> -----------------------------------------------------
>
> Key: BEAM-8933
> URL: https://issues.apache.org/jira/browse/BEAM-8933
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Kirill Kozlov
> Assignee: Kirill Kozlov
> Priority: Major
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> As of right now BigQuery uses Avro format for reading and writing.
> We should add a config to BigQueryIO to specify which format to use: Arrow or
> Avro (with Avro as default).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
