[ 
https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034076#comment-17034076
 ] 

Luke Cwik commented on BEAM-9288:
---------------------------------

If gcs io is shading conscrypt, then it should fix it's shading. It should rely 
on a provided conscrypt unless gcs io marks the dependency as provided.

Apache beam should fix it's own usage to not interfere with others usage of it 
and not have users depend on it.

> Conscrypt shaded dependency
> ---------------------------
>
>                 Key: BEAM-9288
>                 URL: https://issues.apache.org/jira/browse/BEAM-9288
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Esun Kim
>            Assignee: sunjincheng
>            Priority: Major
>
> Conscrypt is not designed to be shaded properly mainly because of so files. I 
> happened to see BEAM-9030 (*1) creating a new vendored gRPC shading Conscrypt 
> (*2) in it. I think this could make a problem when new Conscrypt is brought 
> by new gcsio depending on gRPC-alts (*4) in a dependency chain. (*5) In this 
> case, it may have a conflict when finding proper so files for Conscrypt. 
> *1: https://issues.apache.org/jira/browse/BEAM-9030
> *2:  
> [https://github.com/apache/beam/blob/e24d1e51cbabe27cb3cc381fd95b334db639c45d/buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy#L78]
> *3: https://issues.apache.org/jira/browse/BEAM-6136
> *4: [https://mvnrepository.com/artifact/io.grpc/grpc-alts/1.27.0]
> *5: https://issues.apache.org/jira/browse/BEAM-8889
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to