[ https://issues.apache.org/jira/browse/BEAM-9229?focusedWorklogId=386900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386900 ]
ASF GitHub Bot logged work on BEAM-9229: ---------------------------------------- Author: ASF GitHub Bot Created on: 13/Feb/20 21:48 Start Date: 13/Feb/20 21:48 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #10733: [BEAM-9229] Adding dependency information to Environment proto URL: https://github.com/apache/beam/pull/10733#discussion_r379132449 ########## File path: model/pipeline/src/main/proto/beam_runner_api.proto ########## @@ -1093,6 +1093,72 @@ message SideInput { FunctionSpec window_mapping_fn = 3; } +message StandardArtifacts { + enum Types { + // A URN for artifacts stored in a local directory. + // payload: ArtifactFilePayload. + FILE = 0 [(beam_urn) = "beam:artifact:file:v1"]; + + // A URN for artifacts embedded in ArtifactInformation proto. + // payload: EmbeddedFilePayload. + EMBEDDED = 1 [(beam_urn) = "beam:artifact:embedded:v1"]; + + // A URN for artifacts described by remote URLs. + // payload: a string for an artifact URL e.g. "https://.../foo.jar" + REMOTE = 2 [(beam_urn) = "beam:artifact:remote:v1"]; + + // A URN for Python artifacts hosted on PYPI. + // payload: PypiPayload + PYPI = 3 [(beam_urn) = "beam:artifact:pypi:v1"]; + + // A URN for Java artifacts hosted on Maven central. + // payload: MavenPayload + MAVEN = 4 [(beam_urn) = "beam:artifact:maven:v1"]; + } +} + +message ArtifactFilePayload { + // A path to an artifact file on a local system. + string local_path = 1; + + // A generated staged name (no path). + string staged_name = 2; +} + +message EmbeddedFilePayload { + // raw data bytes for an embedded artifact + bytes data = 1; + + // A generated staged name (no path). + string staged_name = 2; +} + +message PypiPayload { + // Pypi compatible artifact id e.g. "apache-beam" + string pypi_artifact_id = 1; + + // Pypi compatible version string. + string pypi_version_range = 2; +} + +message MavenPayload { + // Maven compatible group id e.g. "org.apache.beam" + string maven_group_id = 1; Review comment: Note that group/artifact/version isn't enough to fully specify all types of maven artifacts. Either use a single string to specify the artifact `groupId:artifactId:version[:packaging[:classifier]]` where packaging and classifier are optional and packaging by default is "jar" and classifier is omitted if unspecified. Or add `classifier` and `type` and rename `maven_group_id` to `group_id`, `maven_artifact_id` to `artifact_id` and `maven_version_range` to `version`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 386900) Time Spent: 3h 20m (was: 3h 10m) > Adding dependency information to Environment proto > -------------------------------------------------- > > Key: BEAM-9229 > URL: https://issues.apache.org/jira/browse/BEAM-9229 > Project: Beam > Issue Type: Sub-task > Components: beam-model > Reporter: Heejong Lee > Assignee: Heejong Lee > Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > Adding dependency information to Environment proto. -- This message was sent by Atlassian Jira (v8.3.4#803005)