[
https://issues.apache.org/jira/browse/BEAM-9229?focusedWorklogId=386971&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386971
]
ASF GitHub Bot logged work on BEAM-9229:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/20 23:58
Start Date: 13/Feb/20 23:58
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10733: [BEAM-9229]
Adding dependency information to Environment proto
URL: https://github.com/apache/beam/pull/10733#discussion_r379185959
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1093,6 +1093,72 @@ message SideInput {
FunctionSpec window_mapping_fn = 3;
}
+message StandardArtifacts {
+ enum Types {
+ // A URN for artifacts stored in a local directory.
+ // payload: ArtifactFilePayload.
+ FILE = 0 [(beam_urn) = "beam:artifact:file:v1"];
+
+ // A URN for artifacts embedded in ArtifactInformation proto.
+ // payload: EmbeddedFilePayload.
+ EMBEDDED = 1 [(beam_urn) = "beam:artifact:embedded:v1"];
+
+ // A URN for artifacts described by remote URLs.
+ // payload: a string for an artifact URL e.g. "https://.../foo.jar";
+ REMOTE = 2 [(beam_urn) = "beam:artifact:remote:v1"];
Review comment:
Regarding the file payload, I think we may want to stage this under a
different name than its "real" name. However, I think the stage name needs to
be lifted to a higher level and apply to all artifact types.
One reason to keep file separate than URL is that we may want to set the
space of files be those understood by (and fetched via) the beam filesystems
packages (including remote, non-(public?)-url ones like gcs or aws).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 386971)
Time Spent: 3h 40m (was: 3.5h)
> Adding dependency information to Environment proto
> --------------------------------------------------
>
> Key: BEAM-9229
> URL: https://issues.apache.org/jira/browse/BEAM-9229
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Adding dependency information to Environment proto.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
