[
https://issues.apache.org/jira/browse/BEAM-9474?focusedWorklogId=400391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400391
]
ASF GitHub Bot logged work on BEAM-9474:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/20 22:08
Start Date: 09/Mar/20 22:08
Worklog Time Spent: 10m
Work Description: tweise commented on pull request #11084: [BEAM-9474]
Improve robustness of BundleFactory and ProcessEnvironment
URL: https://github.com/apache/beam/pull/11084#discussion_r389984708
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
##########
@@ -166,11 +168,20 @@ public static DefaultJobBundleFactory create(
CacheBuilder.newBuilder()
.removalListener(
(RemovalNotification<Environment, WrappedSdkHarnessClient>
notification) -> {
- int refCount = notification.getValue().unref();
- LOG.debug(
- "Removed environment {} with {} remaining bundle
references.",
- notification.getKey(),
- refCount);
+ WrappedSdkHarnessClient client = notification.getValue();
+ int refCount = client.unref();
+ // Double-check to trigger closing of all environments in
case the "refing" does
+ // not clean them up during operator shutdown. This is
necessary in some
+ // situations, e.g when the bundle cannot be closed and thus
the ref cannot be
+ // released. All environment types ensure they can only be
closed once.
+ if (refCount > 0) {
+ LOG.warn(
+ "Clearing remaining {} bundle references from
environment {} to ensure it shuts down.",
+ refCount,
+ notification.getKey());
+ //noinspection StatementWithEmptyBody
Review comment:
Why is this needed (with the log statement above)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 400391)
Time Spent: 0.5h (was: 20m)
> Environment cleanup is not robust enough and may leak resources
> ---------------------------------------------------------------
>
> Key: BEAM-9474
> URL: https://issues.apache.org/jira/browse/BEAM-9474
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The cleanup code in {{DefaultJobBundleFactory}} and its {{RemoteEnvironment}}
> s may leak resources. This is especially a concern when the execution engines
> reuses the same JVM or underlying machines for multiple runs of a pipeline.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
