[ https://issues.apache.org/jira/browse/BEAM-9474?focusedWorklogId=400416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400416 ]
ASF GitHub Bot logged work on BEAM-9474: ---------------------------------------- Author: ASF GitHub Bot Created on: 09/Mar/20 22:34 Start Date: 09/Mar/20 22:34 Worklog Time Spent: 10m Work Description: mxm commented on pull request #11084: [BEAM-9474] Improve robustness of BundleFactory and ProcessEnvironment URL: https://github.com/apache/beam/pull/11084#discussion_r389998456 ########## File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/ProcessEnvironment.java ########## @@ -64,13 +63,32 @@ public InstructionRequestHandler getInstructionRequestHandler() { } @Override - public void close() throws Exception { - synchronized (lock) { - if (!isClosed) { - instructionHandler.close(); - processManager.stopProcess(workerId); - isClosed = true; + public synchronized void close() throws Exception { + if (isClosed) { + return; + } + Exception exception = null; + try { + processManager.stopProcess(workerId); + } catch (Exception e) { + if (exception != null) { Review comment: I intentionally didn't do that. If you move around the the try block to change the order, this will break. I'd prefer to be defensive. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 400416) Time Spent: 1h 20m (was: 1h 10m) > Environment cleanup is not robust enough and may leak resources > --------------------------------------------------------------- > > Key: BEAM-9474 > URL: https://issues.apache.org/jira/browse/BEAM-9474 > Project: Beam > Issue Type: Bug > Components: java-fn-execution > Reporter: Maximilian Michels > Assignee: Maximilian Michels > Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > The cleanup code in {{DefaultJobBundleFactory}} and its {{RemoteEnvironment}} > s may leak resources. This is especially a concern when the execution engines > reuses the same JVM or underlying machines for multiple runs of a pipeline. -- This message was sent by Atlassian Jira (v8.3.4#803005)