[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=408983&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408983
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/20 17:54
Start Date: 24/Mar/20 17:54
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #11199: [BEAM-9562]
Update Timer encoding to V2
URL: https://github.com/apache/beam/pull/11199#discussion_r397351447
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -609,16 +609,20 @@ message Elements {
// represents the producer of these timers.
string transform_id = 2;
+ // (Optional) The local timer family name used to identify the associated
+ // timer family specification
+ string timer_family_tag = 3;
+
// (Optional) The local timer name used to identify the associated timer
specification.
- string timer_id = 3;
+ string timer_id = 4;
// (Optional) Represents a logical byte stream of a timer. Encoded
according
// to the coder in the timer spec.
- bytes timer = 4;
+ bytes timer = 5;
Review comment:
The `Elements` has repeated field of `Timer`. So I think the `Timer`
represents a single timer, and `Element` represent a full stream of timers for
one bundle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 408983)
Time Spent: 2h (was: 1h 50m)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
