[ https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=409641&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409641 ]
ASF GitHub Bot logged work on BEAM-9562: ---------------------------------------- Author: ASF GitHub Bot Created on: 25/Mar/20 16:52 Start Date: 25/Mar/20 16:52 Worklog Time Spent: 10m Work Description: boyuanzz commented on pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload URL: https://github.com/apache/beam/pull/11216#discussion_r398011965 ########## File path: sdks/python/apache_beam/transforms/userstate.py ########## @@ -141,6 +143,13 @@ def __init__(self, name, time_domain): def __repr__(self): return '%s(%s)' % (self.__class__.__name__, self.name) + def to_timer_family_runner_api(self, context): Review comment: I'm working on the Java changes meanwhile having some python tests to run to catch any breakages. Changing to `to_runner_api` is the next step. We should also remove `TimerSpec` definition from proto as long as nowhere else uses it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 409641) Time Spent: 2h 50m (was: 2h 40m) > Remove timer from PCollection and treat timers as Elements > ----------------------------------------------------------- > > Key: BEAM-9562 > URL: https://issues.apache.org/jira/browse/BEAM-9562 > Project: Beam > Issue Type: New Feature > Components: sdk-py-harness > Reporter: Boyuan Zhang > Assignee: Boyuan Zhang > Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)